Skip to content

Conversation

@pyu10055
Copy link
Collaborator

@pyu10055 pyu10055 commented Sep 24, 2020

When integrating with TFX OSS, some pip dependencies problem was found, namely:

  1. we are depending on tensorflow-cpu, which conflict with TFX dependencies of Tensorflow
  2. we are using PyInquirer which uses an old prompt-toolkit that conflict with one of TFX dependencies

Since TFX does not need the wizard and tfjs converter should work with TensorFlow pip as well, we decide to make following changes:

  1. Update the tensorflow-cpu dependencies to tensorflow, since this is mainly a size consideration.
  2. use the extra_require as following:
    extras_require = {
      "wizard": ["PyInquirer==1.0.3"]
    }

when users need to install tensorflowjs pip, they need to do

pip install tensorflowjs[wizard]

Update the READMEs, and will print error message if the PyInquirer is not installed when users run tensorflow_wizard command.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

Copy link
Collaborator

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @lina128)

@pyu10055 pyu10055 merged commit aa21d70 into master Sep 24, 2020
@pyu10055 pyu10055 deleted the tfx_pip branch September 24, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants