Check for null returned from canvas.getContext #3970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getWebGLRenderingContext can clearly return null. This is expected behavior, because canvas.getContext can return null. We therefore must check for null before trying to call .isContextLost on it.
Contributor
Author
|
For further context, see #3969 |
annxingyuan
reviewed
Sep 29, 2020
| if (!(webGLVersion in contexts)) { | ||
| contexts[webGLVersion] = getWebGLRenderingContext(webGLVersion); | ||
| const newCtx = getWebGLRenderingContext(webGLVersion); | ||
| if (newCtx) { |
annxingyuan
suggested changes
Sep 29, 2020
Contributor
annxingyuan
left a comment
annxingyuan
left a comment
There was a problem hiding this comment.
Thanks @jameshfisher ! Just left a small comment.
annxingyuan
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getWebGLRenderingContext can clearly return null.
This is expected behavior, because canvas.getContext can return null.
We therefore must check for null before trying to call .isContextLost on it.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is