Skip to content

Avoid keeping pointer to temporary strings #4016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 6, 2020
Merged

Avoid keeping pointer to temporary strings #4016

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6177e71
Avoid keeping pointer to temporary strings
estyrke Oct 5, 2020
38fd85b
Merge branch 'master' into fix-dangling-pointers
pyu10055 Oct 6, 2020
e3f3052
Merge branch 'master' into fix-dangling-pointers
pyu10055 Oct 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tfjs-node/binding/tfjs_backend.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1134,12 +1134,12 @@ napi_value TFJSBackend::RunSavedModel(napi_env env,
std::string name(input_op_name_array[i]);
int index = name.find(":");
std::string input_op_name = name.substr(0, index);
const char *input_op_index = name.substr(index + 1).c_str();
std::string input_op_index = name.substr(index + 1);
int input_tensor_index;
if (strlen(input_op_index) == 0) {
if (input_op_index.length() == 0) {
input_tensor_index = 0;
} else {
input_tensor_index = atoi(input_op_index);
input_tensor_index = atoi(input_op_index.c_str());
}

// Add input op into input ops list.
Expand All @@ -1162,12 +1162,12 @@ napi_value TFJSBackend::RunSavedModel(napi_env env,
std::string name(output_op_name_array[i]);
int index = name.find(":");
std::string output_op_name = name.substr(0, index);
const char *output_op_index = name.substr(index + 1).c_str();
std::string output_op_index = name.substr(index + 1);
int output_tensor_index;
if (strlen(output_op_index) == 0) {
if (output_op_index.length() == 0) {
output_tensor_index = 0;
} else {
output_tensor_index = atoi(output_op_index);
output_tensor_index = atoi(output_op_index.c_str());
}

TF_Operation *output_op = TF_GraphOperationByName(
Expand Down