Semver-based upper constraints for dependencies #4017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assuming each project follows the semantic versioning, stable projects (version>=1.0.0) guarantees backward compatibility across the same major versions, so we might cap the max version to the next major version for safety. Also curious there's a special reason for having numpy<1.19.0 constraints. If 1.19.0 was a problematic version we might want to exclude culprit versions only, not an upper cap.
pyu10055
approved these changes
Oct 5, 2020
Collaborator
pyu10055
left a comment
pyu10055
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming each project follows the semantic versioning, stable projects (version>=1.0.0) guarantees backward compatibility across the same major versions, so we might cap the max version to the next major version for safety.
Also curious there's a special reason for having numpy<1.19.0 constraints. If 1.19.0 was a problematic version we might want to exclude culprit versions only, not an upper cap.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is