Update TFX_DAG_NAME constant#5563
Merged
copybara-service[bot] merged 1 commit intomasterfrom Apr 6, 2023
Merged
Conversation
updating TFX_DAG_NAME contant to agro compliant name to fix below error. Ref issue: #5528 "error_details":"Internal error: spec.templates[0].name: '_tfx_dag' is invalid: name must consist of alpha-numeric characters or '-', and must start with an alpha-numeric character (e.g. My-name1-2, 123-NAME)
Contributor
Author
|
Created this PR to update TFX_DAG_NAME constant to agro complaint name to fix #5528 issue. Please review. Thank you! |
|
CC @polydier1 |
Contributor
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
Contributor
Author
|
@1025KB, This PR is pending for sometime. Please review. Thank you! |
1025KB
approved these changes
Jan 13, 2023
gbaned
added
ready to pull
gbaned
added
ready to pull
gbaned
added
ready to pull
gbaned
added
ready to pull
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 4, 2023
PiperOrigin-RevId: 519131625
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 4, 2023
PiperOrigin-RevId: 519131625
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 4, 2023
PiperOrigin-RevId: 519131625
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 6, 2023
PiperOrigin-RevId: 521672262
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updating TFX_DAG_NAME contant to agro compliant name to fix below error. Ref issue: #5528
"error_details":"Internal error: spec.templates[0].name: '_tfx_dag' is invalid: name must consist of alpha-numeric characters or '-', and must start with an alpha-numeric character (e.g. My-name1-2, 123-NAME)