feat: get desired state implementation #1362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seriousben
force-pushed
the
seriousben/get_desired_state_impl
branch
11 times, most recently
from
3f7bbef to
ab85ace
Compare
diptanu
force-pushed
the
seriousben/get_desired_state_impl
branch
from
6393273 to
e79527b
Compare
eabatalov
reviewed
Apr 25, 2025
| monitoring_server_host=monitoring_server_host, | ||
| monitoring_server_port=monitoring_server_port, | ||
| enable_grpc_state_reconciler=enable_grpc_state_reconciler, | ||
| enable_grpc_state_reconciler=True, |
Contributor
There was a problem hiding this comment.
Looks good, I'll be removing the old code paths in Executor once we transition to grpc.
eabatalov
reviewed
Apr 25, 2025
| ignored_clock=new_state.clock, | ||
| ) | ||
| continue # Duplicate or outdated message state sent by Server. | ||
| # TODO: The clock is only incremented when function executors have actionable changes and not on new allocations. |
Contributor
There was a problem hiding this comment.
Is it possible to fix this in the future without much effort?
eabatalov
reviewed
Apr 25, 2025
| reducer=output.reducer, | ||
| ) | ||
| output_files: List[Any] = [] | ||
| if output is None: |
Contributor
There was a problem hiding this comment.
Yeah this code doesn't make any sense :)
This improves time to detect FE failures.
As Executor is now pushing its state periodically to Server we can't rely on sequences of events happening within a certain strict-ish duration so we can't make assertions on these durations anymore. Removing the tests that do such assertions for now until we have a better approach to implement such tests.
I changed the test to not run invocations sequentially but run them in parallel. This is because when running sequentially there's effectively 1 task at a time available to get distributed among 2 idle executors and it's not important to route this task randomly to the executors. After making it parallel we have 1200 enqued tasks and we get really good uniform distribution in the test and it's passing now.
The main idea is to not measure the extra 5 sec latency of Server learning from Executor that Function Executor was created successfully.
diptanu
approved these changes
Apr 26, 2025
Collaborator
diptanu
left a comment
diptanu
left a comment
There was a problem hiding this comment.
@eabatalov @seriousben Merging this since tests are green. Unblocks me. Prayers Up for our production 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
What
Testing
Contribution Checklist
make fmtin the package directory.make fmtinserver/.