Conversation
ganler
approved these changes
Mar 8, 2020
Comment on lines
+41
to
+43
| ttl::tensor<float, 3> upsample_conf_(upsample_conf_dim); // 5FPS | ||
| ttl::tensor<float, 3> upsample_paf_(upsample_paf_dim); // 5FPS | ||
| peak_finder_t<float> peak_finder_( |
Contributor
There was a problem hiding this comment.
After removing thread_local, it did work. But this will hurt performance. Especially there's much device/host allocation stuff in peak_finder_t. I'd like to figure out the reason why this thread_local variable failed to deconstruct. BTW, I think we'd better make a "lazy allocation" in peak_finder_t. (it hurts performance when we don't use the gpu version of maxpooling).
Member
Author
There was a problem hiding this comment.
Yes, this fix is too aggressive.
I only merged the first commit.
Comment on lines
+25
to
+42
| DEFINE_string(data_dir, "../../data/media", "path to data folder"); | ||
| DEFINE_string(image_files, | ||
| "../../data/media/COCO_val2014_000000000192.jpg," | ||
| "../../data/media/COCO_val2014_000000000459.jpg," | ||
| "../../data/media/COCO_val2014_000000000415.jpg," | ||
| "../../data/media/COCO_val2014_000000000564.jpg," | ||
| "../../data/media/COCO_val2014_000000000294.jpg," | ||
| "../../data/media/COCO_val2014_000000000623.jpg," | ||
| "../../data/media/COCO_val2014_000000000357.jpg," | ||
| "../../data/media/COCO_val2014_000000000488.jpg," | ||
| "../../data/media/COCO_val2014_000000000589.jpg," | ||
| "../../data/media/COCO_val2014_000000000474.jpg," | ||
| "../../data/media/COCO_val2014_000000000338.jpg," | ||
| "../../data/media/COCO_val2014_000000000569.jpg," | ||
| "../../data/media/COCO_val2014_000000000544.jpg," | ||
| "../../data/media/COCO_val2014_000000000428.jpg," | ||
| "../../data/media/COCO_val2014_000000000536.jpg," | ||
| "../../data/media/COCO_val2014_000000000395.jpg", | ||
| "COCO_val2014_000000000192.jpg," | ||
| "COCO_val2014_000000000459.jpg," | ||
| "COCO_val2014_000000000415.jpg," | ||
| "COCO_val2014_000000000564.jpg," | ||
| "COCO_val2014_000000000294.jpg," | ||
| "COCO_val2014_000000000623.jpg," | ||
| "COCO_val2014_000000000357.jpg," | ||
| "COCO_val2014_000000000488.jpg," | ||
| "COCO_val2014_000000000589.jpg," | ||
| "COCO_val2014_000000000474.jpg," | ||
| "COCO_val2014_000000000338.jpg," | ||
| "COCO_val2014_000000000569.jpg," | ||
| "COCO_val2014_000000000544.jpg," | ||
| "COCO_val2014_000000000428.jpg," | ||
| "COCO_val2014_000000000536.jpg," | ||
| "COCO_val2014_000000000395.jpg", |
Contributor
There was a problem hiding this comment.
Maybe we just specify the folder and glob the image files using filesystem.
luomai
added a commit
that referenced
this pull request
Mar 8, 2020
debug and cleanup (cherrypicked from #238)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.