Various fixes for AverageEmbeddingInputLayer #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove irrelevant references, and clarify that it's not just used for FastText
tomtung
commented
Oct 10, 2017
| pad_value=0, | ||
| name='average_embedding_layer', | ||
| embeddings_initializer=tf.random_uniform_initializer(-0.1, 0.1), | ||
| embeddings_kwargs={} |
There was a problem hiding this comment.
mutable default argument values are generally not a good idea. e.g. see here
There was a problem hiding this comment.
Cool, please also make sure the tutorial_imdb_fasttext.py can run well ~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it's now part of the library, I guess we have to polish it up properly then :)