Skip to content

Conversation

@zsdonghao
Copy link
Member

No description provided.

@luomai luomai self-requested a review February 19, 2018 02:27
References
-----------
`Audio Super Resolution Implementation <https://github.com/kuleshov/audio-super-res/blob/master/src/models/layers/subpixel.py>`__.
- `Audio Super Resolution Implementation <https://github.com/kuleshov/audio-super-res/blob/master/src/models/layers/subpixel.py>`__.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only use listing if we have more than one bullet.

reverse_dictionary : dictionary
FOr converting ID to word.
dictionary
For converting ID to word.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A dictionary that maps IDs to words.

Returns
--------
float/int/str
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the correct syntax here. maybe we shall separate them using commas?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgarithm any idea here?

if dataset is small, we can set it to None.
cost : TensorFlow expression or None
Metric for cost or others.
- If None, would not print the information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using listing only when there are more than one bullets.

If None, it will default to the value 0 with type dtype
None for default
The value to represnt `OFF`.
- If None, it will default to the value 0.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No listing here

@luomai luomai merged commit 1788549 into master Feb 19, 2018
@luomai luomai deleted the check-return branch February 19, 2018 13:05
luomai pushed a commit that referenced this pull request Nov 21, 2018
* check layers docs

* check cost docs

* check prepro

* fixed DeformableConv2d TODO

* check iterate

* check utils

* check nlp

* check rein

* check files

* check visulize

* check activation

* yapf

* fix utils docs

* add ops back

* add supress stdout back for compatibility.

* add an alias for ops.supress_output

* fix indentation

* fix all docs warnings.

* fix luomai comment

* nlp

* fix nlp typos.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants