Fix issues suggested by codacy. #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@luomai @zsdonghao could you help setup the webhook for codacy, instruction is here. |
Member
Author
|
@luomai @zsdonghao when you finish setup the webhook, please reply to this thread, to trigger a comment event. |
zsdonghao
previously approved these changes
Feb 22, 2018
lgarithm
changed the title
Member
Author
|
still not reviewed by codacy, don't merge. |
lgarithm
changed the title
lgarithm
changed the title
Member
Author
lgarithm
commented
Feb 22, 2018
example/tutorial_mnist.py
Outdated
| # placeholder | ||
| x = tf.placeholder(tf.float32, shape=[None, 784], name='x') | ||
| y_ = tf.placeholder( | ||
| tf.placeholder( |
Member
Author
There was a problem hiding this comment.
The whole statement should be removed, not just y_
y_ = tf.placeholder(
tf.int64, shape=[
None,
], name='y_')
lgarithm
commented
Feb 22, 2018
example/tutorial_mnist.py
Outdated
| # Define fine-tune process | ||
| y = network.outputs | ||
| y_op = tf.argmax(tf.nn.softmax(y), 1) | ||
| tf.argmax(tf.nn.softmax(y), 1) |
Member
Author
There was a problem hiding this comment.
tf.argmax(tf.nn.softmax(y), 1)
should also be removed
lgarithm
commented
Feb 22, 2018
| return | ||
| print("Converting data into %s ..." % filename) | ||
| cwd = os.getcwd() | ||
| # cwd = os.getcwd() |
Member
Author
There was a problem hiding this comment.
just delete this line if now used.
luomai
reviewed
Feb 22, 2018
| import tensorlayer as tl | ||
| from PIL import Image | ||
| from tensorlayer.layers import * | ||
| """Reimplementation of the TensorFlow official CIFAR-10 CNN tutorials: |
| EN: https://medium.com/emergent-future/simple-reinforcement-learning-with-tensorflow-part-0-q-learning-with-tables-and-neural-networks-d195264329d0#.5m3361vlw | ||
| CN: https://zhuanlan.zhihu.com/p/25710327 | ||
| """ | ||
| # Q-Table learning algorithm, non deep learning - TD Learning, Off-Policy, e-Greedy Exploration |
| from scipy.misc import imread, imresize | ||
| from tensorflow.contrib.slim.python.slim.nets.alexnet import alexnet_v2 | ||
| from tensorflow.contrib.slim.python.slim.nets.inception_v3 import (inception_v3, inception_v3_arg_scope, inception_v3_base) | ||
| # from scipy.misc import imread, imresize |
luomai
changed the title
luomai
approved these changes
Feb 22, 2018
luomai
pushed a commit
that referenced
this pull request
Nov 21, 2018
* remove two dangerous default values * fix mnist tutorial based on codacy * address hao's comments. * remove unused y_op * hao conv.py * hao prepro.py * hao files.py * remove str statement * hao example mnist * yapf * hao cifar10 * hao inceptionv3 * hao ptb tfrecord image processing * hao tutorials * str comment * str docs * Update README.md * remove unused code * minor fix * small fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.