Remove unnecessary check in ElementwiseLayer (issue #376) #377
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luomai
requested changes
Mar 5, 2018
tensorlayer/layers/merge.py
Outdated
| for l in layers[1:]: | ||
| if str(self.outputs.get_shape()) != str(l.outputs.get_shape()): | ||
| raise Exception("Hint: the input shapes should be the same. %s != %s" % (self.outputs.get_shape(), str(l.outputs.get_shape()))) | ||
| # if str(self.outputs.get_shape()) != str(l.outputs.get_shape()): # issue 376 |
There was a problem hiding this comment.
better to delete this line in order to constantly shorten our codebase
luomai
approved these changes
Mar 5, 2018
luomai
changed the title
luomai
pushed a commit
that referenced
this pull request
Nov 21, 2018
* update ElementwiseLayer for #376 * elementwise supports activation * Update merge.py * Update merge.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address the issue 367