Remove the use of global variables. #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgarithm
reviewed
Mar 9, 2018
tensorlayer/layers/core.py
Outdated
| """ | ||
| LayersConfig._layer_name_list = [] | ||
| raise NotImplementedError('TensorLayer relies on TensorFlow to check naming. Remove this function call.') |
There was a problem hiding this comment.
shall we not to raise exception here to provide better user experience.
We can do something like
logging.info('this method is DEPRECATED and has no effect, please remove it from your code.')
In that way we can inform users without crashing their code.
lgarithm
approved these changes
Mar 9, 2018
lgarithm
reviewed
Mar 9, 2018
| """ | ||
| LayersConfig._name_reuse = enable | ||
| logging.warning('this method is DEPRECATED and has no effect, please remove it from your code.') |
There was a problem hiding this comment.
Actually Hao was right, use pass should be enough, because TensorFlow would log the warning.
And I think this code will crash because we don't have a warning method on logging yet.
There was a problem hiding this comment.
I see the warning method was added later, then it's fine here.
zsdonghao
approved these changes
Mar 9, 2018
lgarithm
reviewed
Mar 9, 2018
|
|
||
| # train the network | ||
| tl.utils.fit( | ||
| sess, network, train_op, cost, X_train, y_train, x, y_, acc=acc, batch_size=500, n_epoch=3, print_freq=1, X_val=X_val, y_val=y_val, eval_train=False) |
There was a problem hiding this comment.
can we reduce the model size instead?
luomai
added a commit
that referenced
this pull request
Nov 21, 2018
* fixed bug of time distributed layer and release 2 tests * speed up test mnist * fixed test file name * remove unused code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.