release load SVHN #422
Merged
release load SVHN #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we should use shutil.move instead of |
lgarithm
reviewed
Mar 16, 2018
tensorlayer/files.py
Outdated
| tag_folder_list.sort(key=lambda s: int(s.split('/')[-1])) # folder/images/ddd | ||
| tag_folder_list = load_folder_list(os.path.join(path, "tags")) | ||
|
|
||
| from sys import platform as _platform |
There was a problem hiding this comment.
can we use os.path.basename instead of if else platform
lgarithm
reviewed
Mar 16, 2018
| import sys | ||
| import tarfile | ||
| import zipfile | ||
| import time |
There was a problem hiding this comment.
another import time on #L1130 could be removed now.
lgarithm
reviewed
Mar 16, 2018
| >>> images = tl.files.load_flickr1M_dataset(tag='zebra') | ||
| """ | ||
| import shutil |
There was a problem hiding this comment.
we should almost always put import on top of file:
https://stackoverflow.com/questions/1188640/good-or-bad-practice-in-python-import-in-the-middle-of-a-file
shutil is a standard module in python, it should be cheap to import.
nebulaV
approved these changes
Mar 16, 2018
luomai
pushed a commit
that referenced
this pull request
Nov 21, 2018
* release load SVHN * fixed codacy * fix liguo suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.