fix-mpii-warning #506
fix-mpii-warning #506
Conversation
| head_x2s = anno['annorect']['x2'][0] | ||
| head_y2s = anno['annorect']['y2'][0] | ||
| for annopoint, head_x1, head_y1, head_x2, head_y2 in zip(annopoints, head_x1s, head_y1s, head_x2s, head_y2s): | ||
| if annopoint != []: |
There was a problem hiding this comment.
some python style guide suggests using implicit false,
e.g. https://google.github.io/styleguide/pyguide.html?showone=True/False_evaluations#True/False_evaluations
(I finally found one example.)
@luomai @DEKHTIARJonathan do you like implicit false?
There was a problem hiding this comment.
LGTM as long as we can keep this consistent in our coding style.
There was a problem hiding this comment.
I would defintely go toward the google coding guidelines. TL is an API on top of google product. In order to facilitate the learning curve, we should keep, to my mind, the same pratices whenever it is possible. I perfectly agree with @lgarithm
There was a problem hiding this comment.
@zsdonghao could you change this line to implicit false? Namely if annopoint:
* fix-mpii-warning * google style
Motivation and Context