Skip to content

Conversation

@DEKHTIARJonathan
Copy link
Member

@DEKHTIARJonathan DEKHTIARJonathan commented Apr 20, 2018

This PR goes toward many objectives:

  • Implementing Flake8 coding-style practices
  • Following PEP8 coding-style practices
  • Fixing the small errors in the documentation to remove warning from Sphinx.
  • Adding modules/db to the documentation (if not, it raises an error).

Max Column Length: Changed from 160 to 120 (it was the double of the standard value)

This PR is a remake of #509 which was too clumsy and hardly readable.

@lgarithm as you pointed out yesterday, we should follow Google coding practices.
It was a good idea, this PR goes in this direction.

@DEKHTIARJonathan DEKHTIARJonathan added this to the 1.8.5 milestone Apr 20, 2018
@tensorlayer tensorlayer deleted a comment Apr 20, 2018
@tensorlayer tensorlayer deleted a comment Apr 20, 2018
Copy link
Member

@zsdonghao zsdonghao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a lot of code need to be shorten

@zsdonghao zsdonghao merged commit 98291f0 into master Apr 20, 2018
@zsdonghao zsdonghao deleted the documentation_cleaning branch April 20, 2018 23:54
luomai pushed a commit that referenced this pull request Nov 21, 2018
* Activation Cleaning Docstring Test

* Requirements Pinned with range to insure tested versions are used. Range are used to prevent updating requirements all the time.

* setup.cfg file added with PEP8 configuration

* activation.py refactored

* docstring fixed - ready for documentation unittest

* Yapf correction for max_line_length: 120

* test yapf refactored

* Requirements conflict solved

* Yapf Style modified and merged in file "setup.cfg"

* Yapf Confiuguration Updated

* Code Refactored with new YAPF formating style

* Code Refactored with new YAPF formating style

* Code Refactored with new YAPF formating style

* tl.layers.pooling YAPF reformat

* yapf updated

* gitignore updated

* YAPF Style Fixing Attempt

* Space Error Fix

* Style Correction

* Assertion Codacy Errors Corrected

* Error Fix

* Assertion Refactored

* YAPF Style Applied to Master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants