-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[WIP] - Documentation Cleaning and Coding Style #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nge are used to prevent updating requirements all the time.
# Conflicts: # tensorlayer/files.py
…nto documentation_cleaning
zsdonghao
approved these changes
Apr 20, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a lot of code need to be shorten
luomai
pushed a commit
that referenced
this pull request
Nov 21, 2018
* Activation Cleaning Docstring Test * Requirements Pinned with range to insure tested versions are used. Range are used to prevent updating requirements all the time. * setup.cfg file added with PEP8 configuration * activation.py refactored * docstring fixed - ready for documentation unittest * Yapf correction for max_line_length: 120 * test yapf refactored * Requirements conflict solved * Yapf Style modified and merged in file "setup.cfg" * Yapf Confiuguration Updated * Code Refactored with new YAPF formating style * Code Refactored with new YAPF formating style * Code Refactored with new YAPF formating style * tl.layers.pooling YAPF reformat * yapf updated * gitignore updated * YAPF Style Fixing Attempt * Space Error Fix * Style Correction * Assertion Codacy Errors Corrected * Error Fix * Assertion Refactored * YAPF Style Applied to Master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes toward many objectives:
modules/dbto the documentation (if not, it raises an error).Max Column Length: Changed from 160 to 120 (it was the double of the standard value)
This PR is a remake of #509 which was too clumsy and hardly readable.
@lgarithm as you pointed out yesterday, we should follow Google coding practices.
It was a good idea, this PR goes in this direction.