Skip to content

Conversation

@JoelKronander
Copy link
Contributor

fixes #64
replaces old PR#60
This PR represents a quite extensive clean up of the download functions in files.py.
Using a new utility function called maybe_download_and_extract() the individually, and repetitive definitions of helper functions in the dowload_dataset_X functions has been removed.

Additional functionality on top of more readable code are:

  • Added a progress bar for file downloads, (particular convenient for larger file downloads such as wmt)
  • Adding a new custom dataset download function is now significantly easier by using maybe_download_and_extract()
  • The default path for data download is now set to data/ to be consistent with structure in examples/

All modified download functions have been tested, and all tutorials in examples/ runs properly.

…load function to follow new interface, see PR details for more info
@JoelKronander JoelKronander changed the title Major clean up in dowload functions in files.py Major clean up in dowload dataset functions in files.py Jan 14, 2017
@zsdonghao zsdonghao merged commit d553892 into tensorlayer:master Jan 14, 2017
@JoelKronander JoelKronander deleted the files_updates_and_clean_up branch January 15, 2017 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should load datasets function in tl.files receive path argument to specify the data path?

2 participants