Skip to content

Conversation

@doronHarnoy
Copy link
Member

This Pr is adding custom onnx layers to extend our onnx coverage.
We start here by creating the onnx hard sigmoid operator as custom keras layer.
I converted this package also to poetry for our convenient.

@doronHarnoy doronHarnoy requested review from tip3x and yotamazriel May 22, 2022 06:26
Copy link
Collaborator

@tip3x tip3x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Nice!

I don't like all the x vars but I see it all over the repo anyway

@doronHarnoy
Copy link
Member Author

@tip3x I agree about x vars, but its quite common generally in the keras community and docs to use it.
I can rename it to out_tensor or any other good name you can think of

@doronHarnoy doronHarnoy merged commit 5b6f6a8 into development May 23, 2022
@doronHarnoy doronHarnoy mentioned this pull request May 23, 2022
doronHarnoy added a commit that referenced this pull request May 24, 2022
* convert to poetry

* add make file

* remove unused files

* update license

* throw warning if lambda layers exist

* add custom onnx layer and hard sigmoid in it

* connect hard sigmoid layer to converter

* test hard sigmoid

* add get config for onnx custom layer

* send custom onnx objects map when loading from config

* add keras-data-format-converter

* add all interpolation modes to upsample

* add all deeplab version tests

* add convert_channels_first_to_last to testing
doronHarnoy added a commit that referenced this pull request May 24, 2022
* convert to poetry

* add make file

* remove unused files

* update license

* throw warning if lambda layers exist

* add custom onnx layer and hard sigmoid in it

* connect hard sigmoid layer to converter

* test hard sigmoid

* add get config for onnx custom layer

* send custom onnx objects map when loading from config

* add keras-data-format-converter

* add all interpolation modes to upsample

* add all deeplab version tests

* add convert_channels_first_to_last to testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants