Skip to content

Use our data format converter in model tests #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 24, 2022
Merged

Use our data format converter in model tests #18

merged 2 commits into from
May 24, 2022

Conversation

@doronHarnoy
Copy link
Member

@doronHarnoy doronHarnoy commented May 24, 2022

  • raise on lamda layer exists
  • remove change_ordering from test and use our data format first to last with transform_inputs

@doronHarnoy doronHarnoy requested a review from tip3x May 24, 2022 10:56
tip3x
tip3x approved these changes May 24, 2022
View reviewed changes
Copy link
Collaborator

@tip3x tip3x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tip3x tip3x merged commit 465f1fe into master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tip3x tip3x tip3x approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@doronHarnoy @tip3x