Register tasks in DurableBuilder rather than Durable client#77
Merged
virajmehta merged 1 commit intomainfrom Mar 11, 2026
Merged
Register tasks in DurableBuilder rather than Durable client#77virajmehta merged 1 commit intomainfrom
virajmehta merged 1 commit intomainfrom
Conversation
This enforces that no new tasks can be registered once a Durable client has been constructed. As a result, we can avoid using an RwLock around the TaskRegistry
4625bec to
03b5356
Compare
virajmehta
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enforces that no new tasks can be registered once a Durable client has been constructed. As a result, we can avoid using an RwLock around the TaskRegistry
Note
Medium Risk
This is an API-breaking change that moves task registration to client construction and alters core worker spawn/dispatch paths by removing the registry
RwLock. Risk is moderate because it touches the primary client/worker lifecycle, though behavior is mostly a structural refactor.Overview
Task registration is moved from
DurabletoDurableBuilder. The asyncDurable::register*APIs are removed; tasks are now added viaDurableBuilder::register/register_instancebeforebuild/build_with_state, andspawn_by_name_withvalidates against this immutable registry.Runtime registry access is simplified and lock-free.
Durablenow holds anArc<TaskRegistry>(noRwLock), and worker handler lookup uses direct registry reads. All benches and tests are updated to construct clients/builders with pre-registered tasks (including newBenchContext::with_builder/new_builderpatterns).Written by Cursor Bugbot for commit 03b5356. This will update automatically on new commits. Configure here.