Skip to content

Switch sqlx from ring to aws-lc-rs#87

Merged
Aaron1011 merged 1 commit intomainfrom
aaron/switch-aws-lc-rs
Apr 8, 2026
Merged

Switch sqlx from ring to aws-lc-rs#87
Aaron1011 merged 1 commit intomainfrom
aaron/switch-aws-lc-rs

Conversation

@Aaron1011
Copy link
Copy Markdown
Member

@Aaron1011 Aaron1011 commented Apr 8, 2026

aws-lc-rs has post-quantum cryptography support,
while ring does not


Note

Medium Risk
Changes the TLS crypto backend used by database connections, which can affect runtime compatibility and security behavior. It also introduces new native build dependencies (aws-lc-sys via cmake), increasing CI/build and platform risk.

Overview
Updates sqlx to use the tls-rustls-aws-lc-rs feature instead of tls-rustls, effectively moving Rustls from ring to aws-lc-rs for TLS.

Cargo.lock is refreshed to add the new AWS-LC dependency chain (aws-lc-rs/aws-lc-sys plus build helpers like cmake, fs_extra, dunce, jobserver) and remove ring from the Rustls dependency set.

Reviewed by Cursor Bugbot for commit 8d23e70. Bugbot is set up for automated code reviews on this repo. Configure here.

aws-lc-rs has post-quantum cryptography support,
while ring does not
Copy link
Copy Markdown
Member

@shuyangli shuyangli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems premature but yeah doesn't hurt

@shuyangli shuyangli assigned Aaron1011 and unassigned shuyangli Apr 8, 2026
@Aaron1011 Aaron1011 added this pull request to the merge queue Apr 8, 2026
Merged via the queue into main with commit 06dece0 Apr 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants