Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR escapes Slack notification inputs to prevent potential security issues and JSON injection vulnerabilities in GitHub Actions workflow notifications. The change refactors inline payload definitions to use proper JSON construction with jq for safe input handling.
- Extracts JSON payload construction into dedicated build steps using jq for proper escaping
- Replaces inline YAML payload definitions with references to safely constructed payloads
- Applies consistent escaping pattern across all notification types (issues, comments, PRs, discussions)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
virajmehta
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3718
First PR with Sonnet 4.5
Important
Escapes inputs for Slack notifications in GitHub workflow to prevent injection attacks.
.github/workflows/slack-notifications.ymlusingjqto build payloads for various GitHub events.issues,issue_comment,pull_request_target,pull_request_review,discussion, anddiscussion_comment.This description was created by
for bbeb667. You can customize this summary. It will automatically update as commits are pushed.