Add name to {Chat|Json}InferenceDatapoint (database layer)#3735
Merged
Add name to {Chat|Json}InferenceDatapoint (database layer)#3735
Conversation
ea0ab6e to
aca3445
Compare
75c95da to
53902f1
Compare
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Sep 30, 2025
53902f1 to
c0401a4
Compare
b969b68 to
8e915eb
Compare
c0401a4 to
ad9ec05
Compare
This was referenced Sep 30, 2025
1c8dcf9 to
f2ab723
Compare
ad9ec05 to
d389463
Compare
f2ab723 to
b2a05c3
Compare
0ae4b2b to
19a5486
Compare
c8d4556 to
1945f42
Compare
19a5486 to
42edc19
Compare
1945f42 to
23d7f1a
Compare
42edc19 to
4308282
Compare
4308282 to
2758a58
Compare
This is for both datasets and evaluations. UI will come in a follow-up.
80490ed to
8dd1f7c
Compare
virajmehta
previously approved these changes
Oct 2, 2025
8dd1f7c to
56a632c
Compare
56a632c to
91badd7
Compare
Aaron1011
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds backend type definitions and corresponding ClickHouse migration for an optional "name" to datapoints. Covers both Chat and Json datapoints.
This adds the type definition and any associated tests to both rust and typescript code. We will try to move all Clickhouse query logic from typescript to rust soon to try to better delineate the responsibilities for frontend logic.
A step towards #3653.
Important
Add optional
namefield to Chat and Json inference datapoints, including database migration and updates to type definitions, code, and tests.namecolumn toChatInferenceDatapointandJsonInferenceDatapointtables inmigration_0040.rs.namefield toChatInferenceDatapointandJsonInferenceDatapointtypes in TypeScript and Rust.parseDatapointFormData()inroute.tsxto handlenamefield.getDatapoint()andinsertDatapoint()indatasets.server.tsto includename.getEvaluationResults()andgetEvaluationsForDatapoint()inevaluations.server.tsto handlename.namefield to test cases inrender_inferences.rsandclickhouse.rs.datasets.test.tsandevaluations.test.tsto includenamein assertions.This description was created by
for 026317c. You can customize this summary. It will automatically update as commits are pushed.