Skip to content

Add name to {Chat|Json}InferenceDatapoint (database layer)#3735

Merged
shuyangli merged 10 commits intomainfrom
sl/add-name-to-datapoints
Oct 2, 2025
Merged

Add name to {Chat|Json}InferenceDatapoint (database layer)#3735
shuyangli merged 10 commits intomainfrom
sl/add-name-to-datapoints

Conversation

@shuyangli
Copy link
Copy Markdown
Member

@shuyangli shuyangli commented Sep 29, 2025

Adds backend type definitions and corresponding ClickHouse migration for an optional "name" to datapoints. Covers both Chat and Json datapoints.

This adds the type definition and any associated tests to both rust and typescript code. We will try to move all Clickhouse query logic from typescript to rust soon to try to better delineate the responsibilities for frontend logic.

A step towards #3653.


Important

Add optional name field to Chat and Json inference datapoints, including database migration and updates to type definitions, code, and tests.

  • Database Migration:
    • Adds name column to ChatInferenceDatapoint and JsonInferenceDatapoint tables in migration_0040.rs.
  • Type Definitions:
    • Adds name field to ChatInferenceDatapoint and JsonInferenceDatapoint types in TypeScript and Rust.
  • Code Updates:
    • Updates parseDatapointFormData() in route.tsx to handle name field.
    • Modifies getDatapoint() and insertDatapoint() in datasets.server.ts to include name.
    • Updates getEvaluationResults() and getEvaluationsForDatapoint() in evaluations.server.ts to handle name.
  • Tests:
    • Adds name field to test cases in render_inferences.rs and clickhouse.rs.
    • Updates datasets.test.ts and evaluations.test.ts to include name in assertions.

This description was created by Ellipsis for 026317c. You can customize this summary. It will automatically update as commits are pushed.

@shuyangli shuyangli force-pushed the sl/add-name-to-datapoints branch from ea0ab6e to aca3445 Compare September 29, 2025 21:41
@shuyangli shuyangli changed the base branch from main to graphite-base/3735 September 30, 2025 19:18
@shuyangli shuyangli force-pushed the sl/add-name-to-datapoints branch from 75c95da to 53902f1 Compare September 30, 2025 19:19
@shuyangli shuyangli changed the base branch from graphite-base/3735 to sl/add-table-item-text-component September 30, 2025 19:19
Copy link
Copy Markdown
Member Author

shuyangli commented Sep 30, 2025

@shuyangli shuyangli force-pushed the sl/add-name-to-datapoints branch from 53902f1 to c0401a4 Compare September 30, 2025 19:57
@shuyangli shuyangli force-pushed the sl/add-table-item-text-component branch from b969b68 to 8e915eb Compare September 30, 2025 19:57
@shuyangli shuyangli changed the base branch from sl/add-table-item-text-component to graphite-base/3735 September 30, 2025 21:26
@shuyangli shuyangli force-pushed the sl/add-name-to-datapoints branch from c0401a4 to ad9ec05 Compare September 30, 2025 21:37
@shuyangli shuyangli changed the base branch from graphite-base/3735 to sl/refactor-datapoint-routes September 30, 2025 21:37
@shuyangli shuyangli force-pushed the sl/refactor-datapoint-routes branch from 1c8dcf9 to f2ab723 Compare October 1, 2025 02:36
@shuyangli shuyangli force-pushed the sl/add-name-to-datapoints branch from ad9ec05 to d389463 Compare October 1, 2025 02:36
@shuyangli shuyangli force-pushed the sl/refactor-datapoint-routes branch from f2ab723 to b2a05c3 Compare October 1, 2025 13:40
@shuyangli shuyangli force-pushed the sl/add-name-to-datapoints branch 3 times, most recently from 0ae4b2b to 19a5486 Compare October 1, 2025 14:56
@shuyangli shuyangli force-pushed the sl/refactor-datapoint-routes branch from c8d4556 to 1945f42 Compare October 1, 2025 14:56
@shuyangli shuyangli force-pushed the sl/add-name-to-datapoints branch from 19a5486 to 42edc19 Compare October 1, 2025 16:12
@shuyangli shuyangli force-pushed the sl/refactor-datapoint-routes branch from 1945f42 to 23d7f1a Compare October 1, 2025 16:12
Base automatically changed from sl/refactor-datapoint-routes to main October 1, 2025 18:24
@shuyangli shuyangli marked this pull request as ready for review October 1, 2025 18:51
@shuyangli shuyangli force-pushed the sl/add-name-to-datapoints branch from 42edc19 to 4308282 Compare October 1, 2025 18:56
@shuyangli shuyangli force-pushed the sl/add-name-to-datapoints branch from 4308282 to 2758a58 Compare October 1, 2025 19:35
virajmehta
virajmehta previously approved these changes Oct 2, 2025
@shuyangli shuyangli enabled auto-merge October 2, 2025 16:28
@shuyangli shuyangli added this pull request to the merge queue Oct 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 2, 2025
@shuyangli shuyangli force-pushed the sl/add-name-to-datapoints branch from 8dd1f7c to 56a632c Compare October 2, 2025 18:07
@shuyangli shuyangli force-pushed the sl/add-name-to-datapoints branch from 56a632c to 91badd7 Compare October 2, 2025 18:09
@shuyangli shuyangli enabled auto-merge October 2, 2025 18:11
@shuyangli shuyangli added this pull request to the merge queue Oct 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 2, 2025
@shuyangli shuyangli added this pull request to the merge queue Oct 2, 2025
@shuyangli shuyangli removed this pull request from the merge queue due to a manual request Oct 2, 2025
@shuyangli shuyangli added this pull request to the merge queue Oct 2, 2025
Merged via the queue into main with commit 8f0e41f Oct 2, 2025
30 checks passed
@shuyangli shuyangli deleted the sl/add-name-to-datapoints branch October 2, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants