Skip to content

Try to fix flaky Playwright word_wrap.spec.test#3791

Merged
virajmehta merged 1 commit intomainfrom
aaron/flaky-word-wrap
Oct 1, 2025
Merged

Try to fix flaky Playwright word_wrap.spec.test#3791
virajmehta merged 1 commit intomainfrom
aaron/flaky-word-wrap

Conversation

@Aaron1011
Copy link
Copy Markdown
Member

@Aaron1011 Aaron1011 commented Oct 1, 2025

This has repeatedly flaked on CI, slowing down the model-inference-cache ui tests (since we need to re-reun every single test if any of them fail)


Important

Add a 1-second delay in word_wrap.spec.ts to address test flakiness after page reload.

  • Test Stability:
    • Adds await page.waitForTimeout(1000); in word_wrap.spec.ts to address flakiness after page reload.
    • Comment indicates this is a temporary fix and suggests finding a proper event to wait for.

This description was created by Ellipsis for 36331b3. You can customize this summary. It will automatically update as commits are pushed.

This has repeatedly flaked on CI, slowing down the model-inference-cache
ui tests (since we need to re-reun every single test if any of them
fail)
Copilot AI review requested due to automatic review settings October 1, 2025 20:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR attempts to fix a flaky Playwright test by adding a timeout after page reload. The test validates that word wrap settings persist between page reloads.

  • Adds a 1-second timeout after page reload to address test flakiness

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@virajmehta virajmehta linked an issue Oct 1, 2025 that may be closed by this pull request
@virajmehta virajmehta added this pull request to the merge queue Oct 1, 2025
Merged via the queue into main with commit 6381ecf Oct 1, 2025
31 checks passed
@virajmehta virajmehta deleted the aaron/flaky-word-wrap branch October 1, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix flaky word wrap UI test

3 participants