Try to fix flaky Playwright word_wrap.spec.test#3791
Merged
virajmehta merged 1 commit intomainfrom Oct 1, 2025
Merged
Conversation
This has repeatedly flaked on CI, slowing down the model-inference-cache ui tests (since we need to re-reun every single test if any of them fail)
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR attempts to fix a flaky Playwright test by adding a timeout after page reload. The test validates that word wrap settings persist between page reloads.
- Adds a 1-second timeout after page reload to address test flakiness
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
virajmehta
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has repeatedly flaked on CI, slowing down the model-inference-cache ui tests (since we need to re-reun every single test if any of them fail)
Important
Add a 1-second delay in
word_wrap.spec.tsto address test flakiness after page reload.await page.waitForTimeout(1000);inword_wrap.spec.tsto address flakiness after page reload.This description was created by
for 36331b3. You can customize this summary. It will automatically update as commits are pushed.