Make ts-rs dependency optional in tensorzero-http#7477
Open
Aaron1011 wants to merge 1 commit into
Open
Conversation
This allows external repositories to avoid pulling in a ts-rs dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows external repositories to avoid pulling in a ts-rs dependency
Note
Low Risk
Low risk dependency/feature wiring change, but it may affect downstream builds if they relied on
ts-rsbeing always enabled or on implicit TypeScript export generation.Overview
tensorzero-httpnow feature-gatests-rs(newts-rsfeature; dependency markedoptional) and conditionally derives/exports TS types inApiTypeviacfg_attr.Workspace dependency wiring is updated so internal crates (
tensorzero-core,tensorzero-error,tensorzero-inference-types,tensorzero-overhead,tensorzero-types) depend ontensorzero-httpthroughworkspace = true, while the workspace definition enablestensorzero-http’sts-rsfeature by default.Reviewed by Cursor Bugbot for commit 59337fe. Configure here.