Conversation
yugaoTT
force-pushed
the
yugao/noc2
branch
3 times, most recently
from
ea4601c to
922f2c2
Compare
yugaoTT
requested review from
SeanNijjar,
aagarwalTT,
abhullar-tt,
aliuTT,
cfjchu,
jbaumanTT,
jvegaTT,
omilyutin-tt,
pgkeller,
tt-aho,
tt-asaigal,
tt-dma and
ubcheema
as code owners
yugaoTT
commented
Mar 21, 2025
tests/tt_metal/microbenchmarks/ethernet/test_fabric_edm_bandwidth.py
Outdated
Show resolved
Hide resolved
tt-aho
reviewed
Mar 21, 2025
SeanNijjar
approved these changes
Mar 21, 2025
Contributor
SeanNijjar
left a comment
SeanNijjar
left a comment
There was a problem hiding this comment.
Overall looks good - minor suggestion
tt_metal/hw/inc/dataflow_api.h
Outdated
Contributor
There was a problem hiding this comment.
I think we should take the write_cmd_buf here so this can be useable by the write to local noc and the forward to next EDM paths (I believe those use different cmd bufs atm?)
Contributor
Author
There was a problem hiding this comment.
you mean expose the cmd_buf as input arg?
forward to next edm is not using this api (use the stateful one).
Contributor
There was a problem hiding this comment.
yes that's what I meant. And good point, I forgot about that detail.
abhullar-tt
reviewed
Mar 21, 2025
Contributor
There was a problem hiding this comment.
Just wanted to highlight that on BH we only do inline writes to stream registers. Due to HW bug inline writes to L1 are emulated by first writing the value into src L1 and then doing a Noc async write
jbaumanTT
reviewed
Mar 21, 2025
2 tasks
tt-aho
approved these changes
Mar 22, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 22, 2025
update fabric perf tests to use IRAM by defaults and update targets accordingly. Note this has additional changes which are from this pr: #19440 I have built this branch on top because that will be merged soon and it updates the targets Additionally, several additional unicast tests were added (and a small performance bug in the test kernel resolved). New numbers are as follows (for 4k packet size): | Test Case | Bandwidth GB/s/dir | Comment | |-|-|-| |  | 11.03 | This was the old unicast test but performance has improved due to fix in worker kernel, unicast 1 hop | |  | 9.74 | Unicast, multiple producers/dir, multiple hops, bidir | |  | 9.35 | Currently unclear why this performs worse than above. There should be enough buffering for latency hiding but maybe not | Unicast, single producer/dir, multiple hops, bidir | ### Checklist - [x] [All post commit](https://github.com/tenstorrent/tt-metal/actions/workflows/all-post-commit-workflows.yaml) CI: https://github.com/tenstorrent/tt-metal/actions/runs/14010116751 - [x] New/Existing tests provide coverage for changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use stateful API in fabric worker sync path to save some cycles, also remove sw counter update in noc txn.
some perf numbers
no IRAM
with IRAM
Checklist