Fix errors in ttnn.nlp_create_qkv_heads_decode when input shard is bigger than one tile#19446
Merged
Fix errors in ttnn.nlp_create_qkv_heads_decode when input shard is bigger than one tile#19446
Conversation
05b1c1d to
80db6e0
Compare
avoraTT
approved these changes
Mar 21, 2025
80db6e0 to
3cc8414
Compare
cglagovichTT
approved these changes
Mar 21, 2025
Contributor
cglagovichTT
left a comment
There was a problem hiding this comment.
please update PR title and description with more detail
3cc8414 to
b0f061a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Presently, CreateQKV Decode Op is only tested with hardcoded input shard shape (32, 32).
When relaxing this constraint and moving to bigger shard (32, 128). This results into two issues
What's changed
num_q_coresandnum_kv_cores.Checklist