[CCLs] Port CCLs to 1D fabric #20544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tt-asaigal
reviewed
Apr 11, 2025
tests/ttnn/unit_tests/operations/ccl/test_llama_reduce_scatter_async_TG.py
Show resolved
Hide resolved
| @@ -0,0 +1,55 @@ | |||
| // SPDX-FileCopyrightText: © 2025 Tenstorrent Inc. | |||
Contributor
There was a problem hiding this comment.
For clarity, the functions below are exposed to TTNN CCL ops. They are hence in the API folder.
cc: @pgkeller
Contributor
There was a problem hiding this comment.
Further note - these will be deleted soon as a part of merging fabric code-bases and migrating the "1d" portion of that impl to the proper control plane based APIs
aagarwalTT
requested review from
a team,
SeanNijjar,
TT-BrianLiu,
abhullar-tt,
aliuTT,
avoraTT,
ayerofieiev-tt,
bbradelTT,
cfjchu,
daminakaTT,
davorchap,
djordje-tt,
dmakoviichuk-tt,
dongjin-na,
jbaumanTT,
johanna-rock-tt,
jvegaTT,
kpaigwar,
nhuang-tt,
omilyutin-tt,
pgkeller,
razorback3,
rfurko-tt,
sraizada-tt,
tt-aho,
tt-dma,
ubcheema and
yugaoTT
as code owners
aagarwalTT
force-pushed
the
aagarwal/ccl-port
branch
from
02d4d1b to
8877b86
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 16, 2025
### Ticket [Link to Github Issue](#19961) ### Problem description Currently the ops and tests utilize the fabric setup done via sub-devices. ### What's changed 1. Migrated ops and tests to rather rely on the fabric setup during device init and hence use the appropriate APIs to setup connections with the fabric kernels 2. Cleaned-up tests to get rid of options/vars to setup/teardown fabric 3. Cleaned up the `enable_persistent_fabric_mode` arg indicating that the ops will run in persistent fabric mode by default. ### Checklist - [x] [All post commit](https://github.com/tenstorrent/tt-metal/actions/workflows/all-post-commit-workflows.yaml) CI passes (https://github.com/tenstorrent/tt-metal/actions/runs/14481011716) - [ ] [Blackhole Post commit](https://github.com/tenstorrent/tt-metal/actions/workflows/blackhole-post-commit.yaml) CI passes (if applicable) - [ ] [Model regression](https://github.com/tenstorrent/tt-metal/actions/workflows/perf-models.yaml) CI passes (if applicable) - [ ] [Device performance regression](https://github.com/tenstorrent/tt-metal/actions/workflows/perf-device-models.yaml) CI passes (if applicable) - [ ] **(For models and ops writers)** Full [new models tests](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml) CI passes (if applicable) - [ ] New/Existing tests provide coverage for changes - [ ] [TG Unit Tests](https://github.com/tenstorrent/tt-metal/actions/workflows/tg-unit-tests.yaml) (https://github.com/tenstorrent/tt-metal/actions/runs/14447931719) - [x] [TG Quick](https://github.com/tenstorrent/tt-metal/actions/workflows/tg-quick-trigger.yaml) (https://github.com/tenstorrent/tt-metal/actions/runs/14447914998) - [ ] [TG Demo Test](https://github.com/tenstorrent/tt-metal/actions/workflows/tg-demo-tests.yaml) (https://github.com/tenstorrent/tt-metal/actions/runs/14447942813) - [ ] [TG Nightly](https://github.com/tenstorrent/tt-metal/actions/workflows/tg-nightly-tests.yaml) (https://github.com/tenstorrent/tt-metal/actions/runs/14447925563) - [ ] [TG Frequent Tests](https://github.com/tenstorrent/tt-metal/actions/workflows/tg-frequent-tests.yaml) (https://github.com/tenstorrent/tt-metal/actions/runs/14447936614) - [ ] [TG Model Perf Tests](https://github.com/tenstorrent/tt-metal/actions/workflows/tg-model-perf-tests.yaml) (https://github.com/tenstorrent/tt-metal/actions/runs/14447904540) - [ ] [TG Stress](https://github.com/tenstorrent/tt-metal/actions/workflows/tg-stress-trigger.yaml) (https://github.com/tenstorrent/tt-metal/actions/runs/14447919423) - [ ] [T3K Unit] (https://github.com/tenstorrent/tt-metal/actions/runs/14409722583) - [x] [T3K Nightly] (https://github.com/tenstorrent/tt-metal/actions/runs/14409735747) - [ ] [T3K Frequent] (https://github.com/tenstorrent/tt-metal/actions/runs/14409732454) - [x] [T3K Multiple Pipelines] (https://github.com/tenstorrent/tt-metal/actions/runs/14481016916) --------- Co-authored-by: asaigal <asaigal@tenstorrent.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tt-asaigal
force-pushed
the
aagarwal/ccl-port
branch
from
2e7f5c5 to
d53c1a7
Compare
djordje-tt
added a commit
that referenced
this pull request
Apr 16, 2025
This reverts commit 959239f.
johanna-rock-tt
added a commit
that referenced
this pull request
Apr 16, 2025
This reverts commit 959239f.
tt-asaigal
added a commit
that referenced
this pull request
Apr 16, 2025
This reverts commit 959239f.
tt-asaigal
added a commit
that referenced
this pull request
Apr 16, 2025
This reverts commit 959239f.
roseli-TT
pushed a commit
that referenced
this pull request
Apr 16, 2025
This reverts commit 959239f. Changes getting reverted [here](2665505) (due to broken APC) make this commit non-functional on a 6U. The 6U changes need to go in first. ### Ticket Link to Github Issue ### Problem description Provide context for the problem. ### What's changed Describe the approach used to solve the problem. Summarize the changes made and its impact. ### Checklist - [ ] [All post commit](https://github.com/tenstorrent/tt-metal/actions/workflows/all-post-commit-workflows.yaml) CI passes - [ ] [Blackhole Post commit](https://github.com/tenstorrent/tt-metal/actions/workflows/blackhole-post-commit.yaml) CI passes (if applicable) - [ ] [Model regression](https://github.com/tenstorrent/tt-metal/actions/workflows/perf-models.yaml) CI passes (if applicable) - [ ] [Device performance regression](https://github.com/tenstorrent/tt-metal/actions/workflows/perf-device-models.yaml) CI passes (if applicable) - [ ] **(For models and ops writers)** Full [new models tests](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml) CI passes (if applicable) - [ ] New/Existing tests provide coverage for changes
johanna-rock-tt
added a commit
that referenced
this pull request
Apr 17, 2025
This reverts commit 959239f.
ssinghalTT
pushed a commit
that referenced
this pull request
Apr 23, 2025
### Ticket [Link to Github Issue](#19961) ### Problem description Currently the ops and tests utilize the fabric setup done via sub-devices. ### What's changed 1. Migrated ops and tests to rather rely on the fabric setup during device init and hence use the appropriate APIs to setup connections with the fabric kernels 2. Cleaned-up tests to get rid of options/vars to setup/teardown fabric 3. Cleaned up the `enable_persistent_fabric_mode` arg indicating that the ops will run in persistent fabric mode by default. ### Checklist - [x] [All post commit](https://github.com/tenstorrent/tt-metal/actions/workflows/all-post-commit-workflows.yaml) CI passes (https://github.com/tenstorrent/tt-metal/actions/runs/14481011716) - [ ] [Blackhole Post commit](https://github.com/tenstorrent/tt-metal/actions/workflows/blackhole-post-commit.yaml) CI passes (if applicable) - [ ] [Model regression](https://github.com/tenstorrent/tt-metal/actions/workflows/perf-models.yaml) CI passes (if applicable) - [ ] [Device performance regression](https://github.com/tenstorrent/tt-metal/actions/workflows/perf-device-models.yaml) CI passes (if applicable) - [ ] **(For models and ops writers)** Full [new models tests](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml) CI passes (if applicable) - [ ] New/Existing tests provide coverage for changes - [ ] [TG Unit Tests](https://github.com/tenstorrent/tt-metal/actions/workflows/tg-unit-tests.yaml) (https://github.com/tenstorrent/tt-metal/actions/runs/14447931719) - [x] [TG Quick](https://github.com/tenstorrent/tt-metal/actions/workflows/tg-quick-trigger.yaml) (https://github.com/tenstorrent/tt-metal/actions/runs/14447914998) - [ ] [TG Demo Test](https://github.com/tenstorrent/tt-metal/actions/workflows/tg-demo-tests.yaml) (https://github.com/tenstorrent/tt-metal/actions/runs/14447942813) - [ ] [TG Nightly](https://github.com/tenstorrent/tt-metal/actions/workflows/tg-nightly-tests.yaml) (https://github.com/tenstorrent/tt-metal/actions/runs/14447925563) - [ ] [TG Frequent Tests](https://github.com/tenstorrent/tt-metal/actions/workflows/tg-frequent-tests.yaml) (https://github.com/tenstorrent/tt-metal/actions/runs/14447936614) - [ ] [TG Model Perf Tests](https://github.com/tenstorrent/tt-metal/actions/workflows/tg-model-perf-tests.yaml) (https://github.com/tenstorrent/tt-metal/actions/runs/14447904540) - [ ] [TG Stress](https://github.com/tenstorrent/tt-metal/actions/workflows/tg-stress-trigger.yaml) (https://github.com/tenstorrent/tt-metal/actions/runs/14447919423) - [ ] [T3K Unit] (https://github.com/tenstorrent/tt-metal/actions/runs/14409722583) - [x] [T3K Nightly] (https://github.com/tenstorrent/tt-metal/actions/runs/14409735747) - [ ] [T3K Frequent] (https://github.com/tenstorrent/tt-metal/actions/runs/14409732454) - [x] [T3K Multiple Pipelines] (https://github.com/tenstorrent/tt-metal/actions/runs/14481016916) --------- Co-authored-by: asaigal <asaigal@tenstorrent.com>
ssinghalTT
pushed a commit
that referenced
this pull request
Apr 23, 2025
This reverts commit 959239f. Changes getting reverted [here](2665505) (due to broken APC) make this commit non-functional on a 6U. The 6U changes need to go in first. ### Ticket Link to Github Issue ### Problem description Provide context for the problem. ### What's changed Describe the approach used to solve the problem. Summarize the changes made and its impact. ### Checklist - [ ] [All post commit](https://github.com/tenstorrent/tt-metal/actions/workflows/all-post-commit-workflows.yaml) CI passes - [ ] [Blackhole Post commit](https://github.com/tenstorrent/tt-metal/actions/workflows/blackhole-post-commit.yaml) CI passes (if applicable) - [ ] [Model regression](https://github.com/tenstorrent/tt-metal/actions/workflows/perf-models.yaml) CI passes (if applicable) - [ ] [Device performance regression](https://github.com/tenstorrent/tt-metal/actions/workflows/perf-device-models.yaml) CI passes (if applicable) - [ ] **(For models and ops writers)** Full [new models tests](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml) CI passes (if applicable) - [ ] New/Existing tests provide coverage for changes
djordje-tt
pushed a commit
that referenced
this pull request
Apr 29, 2025
This reverts commit 959239f. Changes getting reverted [here](2665505) (due to broken APC) make this commit non-functional on a 6U. The 6U changes need to go in first. ### Ticket Link to Github Issue ### Problem description Provide context for the problem. ### What's changed Describe the approach used to solve the problem. Summarize the changes made and its impact. ### Checklist - [ ] [All post commit](https://github.com/tenstorrent/tt-metal/actions/workflows/all-post-commit-workflows.yaml) CI passes - [ ] [Blackhole Post commit](https://github.com/tenstorrent/tt-metal/actions/workflows/blackhole-post-commit.yaml) CI passes (if applicable) - [ ] [Model regression](https://github.com/tenstorrent/tt-metal/actions/workflows/perf-models.yaml) CI passes (if applicable) - [ ] [Device performance regression](https://github.com/tenstorrent/tt-metal/actions/workflows/perf-device-models.yaml) CI passes (if applicable) - [ ] **(For models and ops writers)** Full [new models tests](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml) CI passes (if applicable) - [ ] New/Existing tests provide coverage for changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
Currently the ops and tests utilize the fabric setup done via sub-devices.
What's changed
enable_persistent_fabric_modearg indicating that the ops will run in persistent fabric mode by default.Checklist