Unified convolutions cpp api to be same across conv1d conv2d and transpose_conv2d #20563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
Unified convolutions cpp api to be same across
conv1dconv2dandtranspose_conv2d.Is the follow up for conv1d PR
What's changed
Removed conv2d and all functions from python that are already present in conv2d_pybind.
Python consumers should remain unaffected.
C++ consumers will remain unaffected for now, until backwards compatibility functions
in
conv2d.hpparen't removed (eg.invokeandconv2dwith old signatures)Checklist