-
Notifications
You must be signed in to change notification settings - Fork 0
Fix Cases Page API Connection Issue - apiRequest BASE_URL Prepending #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| # Cases Page Launch Issue Fix | ||
|
|
||
| ## Problem | ||
| The cases page was failing to launch because API calls were not reaching the backend server. | ||
|
|
||
| ## Root Cause | ||
| The `apiRequest` function in `src/lib/api.ts` was not prepending the base API URL to relative URLs. This caused requests like `/cases?page=1` to be sent to the frontend server (http://localhost:5173) instead of the backend API server (http://localhost:8000/api/v1). | ||
|
|
||
| ## Solution | ||
| 1. **Updated `apiRequest` function** to prepend `VITE_API_URL` for relative URLs | ||
| 2. **Updated `.env.example`** to show correct API URL including `/api/v1` path | ||
|
|
||
| ## Setup Instructions | ||
|
|
||
| ### 1. Create .env file | ||
| ```bash | ||
| cp .env.example .env | ||
| ``` | ||
|
|
||
| ### 2. Verify API URL in .env | ||
| ```env | ||
| VITE_API_URL=http://localhost:8000/api/v1 | ||
| ``` | ||
|
|
||
| **Important:** The `/api/v1` path is required. Do not use just `http://localhost:8000`. | ||
|
|
||
| ### 3. Start servers | ||
| ```bash | ||
| # Terminal 1 - Backend | ||
| cd backend | ||
| # ... start backend server on port 8000 | ||
|
|
||
| # Terminal 2 - Frontend | ||
| cd frontend | ||
| npm install | ||
| npm run dev | ||
| ``` | ||
|
|
||
| ### 4. Test | ||
| Navigate to http://localhost:5173/cases - the page should now load successfully and fetch case data from the backend. | ||
|
|
||
| ## Files Changed | ||
| - `src/lib/api.ts` - Fixed `apiRequest` to prepend BASE_URL | ||
| - `.env.example` - Updated with correct API URL | ||
|
|
||
| ## Affected Components | ||
| This fix resolves API issues for ALL components using `apiRequest`: | ||
| - CaseList, CaseDetail | ||
| - Forensics, FinalSummary, Ingestion, AdjudicationQueue | ||
| - All adjudication components | ||
| - Evidence API | ||
| - And more... | ||
|
|
||
| ## Production Deployment | ||
| For production, update `VITE_API_URL` to point to your production API server: | ||
| ```env | ||
| VITE_API_URL=https://api.your-domain.com/api/v1 | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Include API error body in exception
New proposed code:
if (!response.ok) { - await response.text().catch(() => 'Unknown error'); - throw new Error(`API request failed: ${response.status} ${response.statusText}`); + const errorBody = await response.text().catch(() => 'Could not read error body'); + throw new Error(`API request failed: ${response.status} ${response.statusText} - ${errorBody}`); }