Open
Conversation
Guard rewrite was corrupting function bodies by mixing input-buffer pointers with output-buffer edits. Track output offsets for i32.const and call, and perform guard move/insert using memmove on the output buffer. Stop mutating the input buffer during rewriting.
Replace leb_out with leb_out_pad to maintain the original LEB128 encoding size when remapping function indices in call instructions. This minimizes binary differences with the mainline output.
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent deletion of non-hook/cbak functions and enable helper calls
Stop deleting functions other than hook/cbak to allow calls from hook/cbak (or other helpers).
This eliminates the need to inline helper functions during development and enables flexible hook coding.