Skip to content

Refactor headerInfo#39

Merged
kortemik merged 15 commits intoteragrep:masterfrom
MoonBow-1:refactor-headerinfo
Aug 21, 2025
Merged

Refactor headerInfo#39
kortemik merged 15 commits intoteragrep:masterfrom
MoonBow-1:refactor-headerinfo

Conversation

@MoonBow-1
Copy link
Copy Markdown
Contributor

@MoonBow-1 MoonBow-1 commented Jul 15, 2025 •
edited
Loading

Separate PR from Pr #15 to make the current PR much more smaller in scope

Closes #42

  • One test will fail, since that is not supposed to be fixed by this PR
  • Makes HeaderInfo immutable as well
  • Will require changes to the PRs that follow this, since the Converter class will be removed in favor of an "event" making itself to a SyslogEvent

@MoonBow-1 MoonBow-1 requested a review from eemhu July 15, 2025 13:08
@MoonBow-1 MoonBow-1 self-assigned this Jul 15, 2025
eemhu
eemhu reviewed Jul 16, 2025
View reviewed changes
Comment thread src/main/java/com/teragrep/cfe_16/RequestHandler.java Outdated
eemhu
eemhu reviewed Jul 16, 2025
View reviewed changes
Comment thread src/main/java/com/teragrep/cfe_16/bo/HeaderInfo.java Outdated
eemhu
eemhu reviewed Jul 16, 2025
View reviewed changes
Comment thread src/main/java/com/teragrep/cfe_16/RequestHandler.java Outdated
eemhu
eemhu reviewed Jul 16, 2025
View reviewed changes
Comment thread src/test/java/com/teragrep/cfe_16/bo/HeaderInfoTest.java Outdated
Laukkala
Laukkala reviewed Aug 8, 2025
View reviewed changes
Comment thread src/test/java/com/teragrep/cfe_16/it/ServiceAndEventManagerIT.java Outdated
@MoonBow-1 MoonBow-1 force-pushed the refactor-headerinfo branch from 9cf6ff4 to bf3000a Compare August 21, 2025 08:34
@MoonBow-1 MoonBow-1 force-pushed the refactor-headerinfo branch from bf3000a to 0f4800a Compare August 21, 2025 08:59
@MoonBow-1
Create objects for HTTP headers
88dc5a0 
- Includes stubs
@MoonBow-1
Implement header classes to HeaderInfo
e64c08a 
- Adds Stubable interface
- Extends the header interfaces from the Stubable interface
@MoonBow-1
Remove unused imports from tests
091dedd
kortemik
kortemik reviewed Aug 21, 2025
View reviewed changes
Comment thread src/main/java/com/teragrep/cfe_16/bo/XForwardedFor.java Outdated
kortemik
kortemik reviewed Aug 21, 2025
View reviewed changes
Comment thread src/main/java/com/teragrep/cfe_16/bo/XForwardedHost.java Outdated
kortemik
kortemik reviewed Aug 21, 2025
View reviewed changes
Comment thread src/main/java/com/teragrep/cfe_16/bo/XForwardedProto.java Outdated
@kortemik kortemik merged commit 1b2cfc1 into teragrep:master Aug 21, 2025
1 check passed
@MoonBow-1 MoonBow-1 deleted the refactor-headerinfo branch February 11, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kortemik kortemik kortemik approved these changes

@eemhu eemhu eemhu left review comments

@Laukkala Laukkala Laukkala left review comments

Assignees

@MoonBow-1 MoonBow-1

Labels

review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor headerInfo

4 participants

@MoonBow-1 @kortemik @eemhu @Laukkala