Blend semi-transparent colors with the terminal background color #20
Conversation
And Fix `Sixel.GetCtrlSeqResponse()`
FIXME: Make configurable in the future
src/Sixel.Supported.cs
Outdated
| public static ReadOnlySpan<char> GetCtrlSeqResponse(string ctrlSeq) | ||
| public static ReadOnlySpan<char> GetCtrlSeqResponse(string ctrlSeq, char? endChar = null) | ||
| { | ||
| char end = ctrlSeq[^1]; | ||
| char end = endChar ?? ctrlSeq[^1]; |
There was a problem hiding this comment.
To allow for general use, it should be possible to specify more than one end-of-reading character.
src/Sixel.Supported.cs
Outdated
| // ^[]11;rgb:2828/2c2c/3434^[\ | ||
| DebugPrint("GetTerminalBackgroundColor: ^[]11;?\\G => ", ConsoleColor.DarkGray); | ||
| var response = GetCtrlSeqResponse($"]11;?{(char)0x07}", '\\'); |
There was a problem hiding this comment.
Note:
Windows Terminal response to OSC 11 ; ? BEL is strange.
The response seems to be OSC 11 ; rgb:RRRR/GGGG/BBBB \, when it really should be OSC 11 ; rgb:RRRR/GGGG/BBBB BEL (the tailing charactor should be BEL)
Right now, it conforms to the Windows Terminal specification, but it should be more generic.
Also, there should probably be a note in the comments.
There was a problem hiding this comment.
ah,, Windows Terminal response may be in the form OSC Ps ; Pt ST .
So it seems to be the correct behavior.
|
Tests were fixed in #21 . |
|
Test says:
|
Enable to specify multiple characters to end the reading of standard input.
…ency Replace to `Sixel.BackgroundColor` when the color table's color is gif's background color
Blend semi-colors with the terminal background color to make it more realistic
Before:
Aflter: