-
Notifications
You must be signed in to change notification settings - Fork 6
[feat] Add dry-run parameter #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
busma13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
➜ ~/WORKSPACE/fetch-github-release git:(b6bac64) ./bin/fetch-github-release -d terascope standard-assets
Release: terascope/standard-assets@v1.3.3
The following files would have been downloaded:
- standard-v1.3.3-node-18-bundle.zip
- standard-v1.3.3-node-20-bundle.zip
- standard-v1.3.3-node-22-bundle.zip
-
➜ ~/WORKSPACE/fetch-github-release git:(b6bac64) ./bin/fetch-github-release -dq terascope standard-assets
terascope/standard-assets@v1.3.3
➜ ~/WORKSPACE/fetch-github-release git:(b6bac64) ./bin/fetch-github-release -dq -o json terascope standard-assets
"terascope/standard-assets@v1.3.3"
➜ ~/WORKSPACE/fetch-github-release git:(b6bac64) ./bin/fetch-github-release -d -o json terascope standard-assets
{
"release": "terascope/standard-assets@v1.3.3",
"assetFileNames": [
"standard-v1.3.3-node-18-bundle.zip",
"standard-v1.3.3-node-20-bundle.zip",
"standard-v1.3.3-node-22-bundle.zip"
]
}
I feel like dryrun, quiet, with json output is pretty useless. I'm not sure what change to suggest.
The readme needs to be updated to show the new options. That can wait until later if we want to get this in.
I agree. The more I think about it, the more I feel like it's a poor and awkward implementation on how |
if the user supplies |
|
We can come back and resolve the -q thing. |
This PR makes the following changes:
dry-runparameter andoutputparameter to the clidry-runwill allow the user to run the command gather metadata on what was filtered from the github apidry-runwill display only the release name in the case that-q quietis also enabledoutputaccepts eitherjsonortext(default) for the user to choose what format the dry-run info will printed in stdout