Fix security vulnerabilities flagged by gosec scanner#75
Merged
Conversation
- Handle error returned by viper.BindEnv() to fix G104 (CWE-703) - Implement URL validation in browser.OpenInBrowser() to prevent command injection vulnerability G204 (CWE-78) Signed-off-by: atilsensalduz <atil.sensalduz@gmail.com>
canack
approved these changes
Feb 26, 2025
Member
canack
left a comment
canack
left a comment
There was a problem hiding this comment.
Nice, thank you for improvement 🎸
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses security vulnerabilities identified by the gosec static analysis tool:
G104 (CWE-703): Unhandled errors in viper.BindEnv() calls
G204 (CWE-78): Command injection vulnerability in browser.OpenInBrowser()
Note
I'm not sure how should we handle if
viper.BindEnvreturns error, I set return error but if it's not proper method to handle it, I can change it to the warning