bin/condense does not support reading node modules

[Raynos]

This line ( https://github.com/marijnh/tern/blob/6844cfa8b05d3dc3f62eb3fa4736348852b33b4e/bin/condense#L68 ) uses path.resolve which won't work if you require("fs") or anything from npm.

Using resolve instead, which is the full node resolution algorithm would allow it to support build in modules and npm modules

The error I have is

$ ./node_modules/tern/bin/condense --plugin node index.js 

fs.js:338
  return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
                 ^
Error: ENOENT, no such file or directory '/home/raynos/Documents/send-data/buffer'
    at Object.fs.openSync (fs.js:338:18)
    at Object.fs.readFileSync (fs.js:182:15)
    at Object.tern.Server.getFile (/home/raynos/Documents/send-data/node_modules/tern/bin/condense:68:39)
    at ensureFile (/home/raynos/Documents/send-data/node_modules/tern/lib/tern.js:229:36)
    at Object.signal.mixin.addFile (/home/raynos/Documents/send-data/node_modules/tern/lib/tern.js:103:7)
    at resolveModule (/home/raynos/Documents/send-data/node_modules/tern/plugin/node.js:70:16)
    at tern.registerPlugin.server._node.modules (/home/raynos/Documents/send-data/node_modules/tern/plugin/node.js:97:16)
    at Object.exports.IsCallee.constraint.addType (/home/raynos/Documents/send-data/node_modules/tern/lib/infer.js:271:9)
    at withWorklist (/home/raynos/Documents/send-data/node_modules/tern/lib/infer.js:639:21)
    at Object.extend.propagate (/home/raynos/Documents/send-data/node_modules/tern/lib/infer.js:88:25)

Which is what happens when it tries to parse this line ( https://github.com/Raynos/send-data/blob/a3bad95e8e018a8e9f82f76868a17df1926b9375/index.js#L1 )

[Raynos]

resolve will return "buffer" or "fs" literally so getFile wouldn't really work on those, I'm not sure how tern handles files in node core.

[marijnh]

The node plugin recognized built-in modules, and won't cause them to be loaded as regular files, so they shouldn't end up in getFile at all. What does the index.js that triggers this look like?

[Raynos]

its loading this ( https://github.com/Raynos/send-data/blob/a3bad95e8e018a8e9f82f76868a17df1926b9375/index.js#L1 )

[marijnh]

The node plugin was missing the definition for the buffer module. Should be better now.

[Raynos]

aha! @marijnh it also looks like it's missing the definition for the timers module

[marijnh]

Indeed, I didn't know that module (I assumed those were all global functions). Should be better now.

[Raynos]

o/ Thanks.

[Raynos]

I ran the latest version of bin/condense against the same file at it works and the output is awesome!

[sqs]

I have another PR with a patch similar to those made for this issue: #218 (adding the module module).