All proposals shown inside string literal #780#781
Closed
mrennie wants to merge 2 commits intoternjs:masterfrom
Closed
All proposals shown inside string literal #780#781mrennie wants to merge 2 commits intoternjs:masterfrom
mrennie wants to merge 2 commits intoternjs:masterfrom
Conversation
Member
|
This is something that I think you should solve on the client side. Or, if that's difficult, add this as a query option that defaults to false. I want the default behavior to stay what it is now. |
Contributor
Author
|
Ok, I'll update the pull request to add a query flag. Any particular name you would prefer for the new flag? |
Member
|
|
Contributor
Author
|
I'm going to close this pull request and open a new one - to avoid the merge commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#780
If there are no loaded plugins that handle completions inside literals, we should return none.
Related Orion bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=492470