Conversation
ocofaigh
requested changes
Apr 23, 2024
Contributor
ocofaigh
left a comment
ocofaigh
left a comment
There was a problem hiding this comment.
2 minor comments - do we want to add anything to the readme?
tests/README.md
Outdated
| @@ -0,0 +1,8 @@ | |||
| <!-- BEGIN TESTS HOOK --> | |||
Contributor
There was a problem hiding this comment.
There is no test hook anymore - remove this
Contributor
Author
There was a problem hiding this comment.
Cool, this may have come from the module template...
tests/README.md
Outdated
| For information about how to create and run tests, see [Validation tests](https://terraform-ibm-modules.github.io/documentation/#/tests) in the project documentation. | ||
|
|
||
| <!-- Add any more steps that are specific to testing this module and that are not in the docs. --> | ||
| <!-- END TESTS HOOK --> |
ocofaigh
approved these changes
Apr 23, 2024
Contributor
|
🎉 This PR is included in version 0.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers