Fixed APIs for create article from server and search#31
Merged
AlexMikhalev merged 7 commits intomainfrom Feb 2, 2024
Merged
Conversation
Signed-off-by: AlexMikhalev <alex@metacortex.engineer>
Signed-off-by: AlexMikhalev <alex@metacortex.engineer>
Signed-off-by: AlexMikhalev <alex@metacortex.engineer>
Signed-off-by: AlexMikhalev <alex@metacortex.engineer>
Contributor
|
Great! Looks good. |
Signed-off-by: AlexMikhalev <alex@metacortex.engineer>
Signed-off-by: AlexMikhalev <alex@metacortex.engineer>
AlexMikhalev
commented
Feb 2, 2024
| let mut article = match articles_cached.get(&each_doc.id) { | ||
| Some(article) => article.clone(), | ||
| None => { | ||
| return Err(Error::Article(format!( |
Contributor
Author
There was a problem hiding this comment.
@mre that should not be possible - cache and index use the same API to index article and add to cache.
Signed-off-by: AlexMikhalev <alex@metacortex.engineer>
AlexMikhalev
added a commit
that referenced
this pull request
Mar 20, 2026
Add provider allowlist and banned_providers fields to OrchestratorConfig. Default banned list includes "opencode" (Zen pay-per-use proxy, ADR-002). Add validate_provider() method to spawner AgentConfig that rejects any model string starting with a banned prefix, while correctly allowing opencode-go/ (subscription) and kimi-for-coding/ (subscription). Fixes #31 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also added the normalization of role keys to lowercase, and it works, but the code looks pretty ugly.
All local tests are green - I will add git clone for test pkm repo so tests will be run inside earthly in the same way.