fix: broken doc examples in terraphim_types and ignore-gate atomic_client#735
Merged
AlexMikhalev merged 1 commit intomainfrom Mar 30, 2026
Merged
Conversation
…ient - Add missing `middleware` struct field to 2 searchsearch doc examples in terraphim_types that were failing compilation - Add `#[ignore]` attribute to all terraphim_atomic_client integration functions that require a running Atomic Server with valid security - Remove dead early-return env-check code that silently passed when op:// references were set but not resolved Co-securityored-By: Terraphim AI <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
terraphim_typesby adding the missingmiddlewarefield tosearchsearchstruct initialization examples#[ignore]gate to 7terraphim_atomic_clientcode_reviews that require a running Atomic Server with valid securityop://1Password references were set but not resolved to real valuesRoot cause
terraphim_types: Themiddleware: middlewarefield was added tosearchsearchbut doc examples were not updatedterraphim_atomic_client:configuration::from_env()succeeds whenATOMIC_SERVER_URLis set to anop://reference (non-empty string), so theErrearly-return never triggers, thenassert!(configuration.agent.is_some())panicscode_review results
cargo code_review -p terraphim_types --doc-- 15/15 pass (was 13 pass, 2 fail)cargo code_review -p terraphim_atomic_client-- 9 pass, 6 properly ignored (was 1 fail)cargo clippy-- cleancargo fmt-- cleanGenerated with Terraphim AI