refactor: remove dead code from url_protector and rolegraph#738
Merged
AlexMikhalev merged 1 commit intomainfrom Mar 30, 2026
Merged
refactor: remove dead code from url_protector and rolegraph#738AlexMikhalev merged 1 commit intomainfrom
AlexMikhalev merged 1 commit intomainfrom
Conversation
- Remove unused _placeholder_counter field from UrlProtector struct (was declared but never read) - Remove commented-out parse_document_to_pair method from RoleGraph (superseded by insert_document) Refs #135 Co-Authored-By: Terraphim AI <noreply@anthropic.com>
AlexMikhalev
added a commit
that referenced
this pull request
Apr 25, 2026
- Remove unused _placeholder_counter field from UrlProtector struct (was declared but never read) - Remove commented-out parse_document_to_pair method from RoleGraph (superseded by insert_document) Refs #135 Co-authored-by: Terraphim AI <noreply@anthropic.com>
AlexMikhalev
added a commit
that referenced
this pull request
Apr 25, 2026
… pull_request_url fallback (Fixes adf-fleet#44)' (#738) from task/fix-outputposter-issue-zero into main
AlexMikhalev
added a commit
that referenced
this pull request
Apr 25, 2026
Documents the full pipeline from DispatchContext through RoutingDecisionEngine (KG + keyword + static merge, C1/C3 filter, budget filter, scoring, telemetry adjustment) through spawn_with_fallback, model_args, the tokio subprocess, exit classification and OutputPoster write-back. Cross-references the code (routing.rs, kg_router.rs, provider_probe.rs, provider_budget.rs, error_signatures.rs, spawner) and the log lines so an operator can read a journal trace alongside it. Includes a worked example from a real security-sentinel dispatch. Also documents the adf-fleet#44 fix (PR #738): pull_request_url fallback for PR-comment issue_number extraction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_placeholder_counterfield fromUrlProtectorstruct (declared but never read, placeholder IDs use a local variable instead)parse_document_to_pairmethod fromRoleGraph(superseded byinsert_document)UrlProtectorto a unit struct with derivedDefaultNote: Items 2 and 4 from #135 (fuzzy_autocomplete_search_jaro_winkler and input.rs) are NOT dead code -- they are actively used by the MCP server and benchmarks respectively.
Refs #135
Test plan
cargo test -p terraphim_automata-- all passcargo test -p terraphim_rolegraph-- all pass (including proptest axioms)cargo clippy-- cleancargo fmt-- cleanGenerated with Terraphim AI