feat: KG-boosted file search with ExternalScorer trait (#222)#754
Merged
Conversation
…Refs #227 Scaffold terraphim_file_search crate integrating fff-search ExternalScorer with terraphim_automata knowledge-graph matching. KgPathScorer scores files by counting unique KG term matches in relative_path with configurable weight_per_term (default 5) and max_boost (default 30). Includes 6 unit tests covering empty thesaurus, path match, no match, multiple terms, cap at max_boost, and hot-reload via update_thesaurus(). Co-Authored-By: Terraphim AI <noreply@terraphim.ai>
#227 - Add fff-search and terraphim_file_search deps to terraphim_mcp_server - Add kg_scorer: Option<Arc<KgPathScorer>> field to McpService - Add with_kg_scorer() builder method for optional KG scorer injection - Implement find_files() method: synchronous FilePicker scan + fuzzy search + KG post-processing re-rank (adds KgPathScorer.score() to fuzzy total, sorts descending) - Expose terraphim_find_files MCP tool with query/path/limit params - Register in list_tools and call_tool dispatch - Add 3 integration tests in tests/test_find_files.rs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…efs #227 Step 6: terraphim_grep MCP tool - Add grep_files() to McpService using fff-search grep_search with KG-aware file ordering (highest KgPathScorer score searched first) - Register terraphim_grep in list_tools and call_tool - Supports query, path, limit, output_mode (content|files) params - Add 2 integration tests: content mode and files-only mode Step 7: KgWatcher hot-reload - Add notify = "8" + notify-debouncer-full = "0.6" to terraphim_file_search - New crates/terraphim_file_search/src/watcher.rs: KgWatcher watches a directory with 500ms debounce and calls update_thesaurus() on change - load_thesaurus_from_dir() merges all JSON files in the watched dir - 2 unit tests: watcher_creates_without_error, watcher_triggers_update All existing tests pass (6 kg_scorer + 3 find_files integration). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Documentation PreviewYour documentation changes have been deployed to: This preview will be available until the PR is closed. |
Switch fff-search from a local filesystem path (which doesn't exist on CI runners) to a git dependency on AlexMikhalev/fff.nvim fork with the ExternalScorer trait. Also fix u64 ID type mismatches from the recent ID refactor, fix pre-existing llm_router test failures (missing llm_enabled flag), resolve clippy warnings, and apply cargo fmt. Refs #222 #227 Co-Authored-By: Terraphim AI <noreply@anthropic.com>
Contributor
Documentation PreviewYour documentation changes have been deployed to: This preview will be available until the PR is closed. |
The fff-search build.rs requires the zlob feature when the CI env var is set. Add --features zlob to clippy, check, and test commands in ci-pr.yml. Also fix terraphim_file_search Cargo.toml where dependencies were misplaced under [features] section. Refs #227 Co-Authored-By: Terraphim AI <noreply@anthropic.com>
Contributor
Documentation PreviewYour documentation changes have been deployed to: This preview will be available until the PR is closed. |
Contributor
Author
|
retrigger |
Contributor
Documentation PreviewYour documentation changes have been deployed to: This preview will be available until the PR is closed. |
Fixes clippy::len_zero warning triggered on CI. Refs #227 Co-Authored-By: Terraphim AI <noreply@anthropic.com>
Contributor
Documentation PreviewYour documentation changes have been deployed to: This preview will be available until the PR is closed. |
AlexMikhalev
added a commit
that referenced
this pull request
Apr 25, 2026
feat: KG-boosted file search with ExternalScorer trait (#222)
AlexMikhalev
added a commit
that referenced
this pull request
May 1, 2026
feat: KG-boosted file search with ExternalScorer trait (#222)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrates FFF (Fast File Finder) scoring engine with terraphim_automata Aho-Corasick knowledge graph matching to create domain-aware file search for AI agents.
Key design decisions
Test plan
Refs #222 #227