fix(tests): make CI tests shallow-clone and server-mode stable#802
Merged
AlexMikhalev merged 1 commit intomainfrom Apr 13, 2026
Merged
fix(tests): make CI tests shallow-clone and server-mode stable#802AlexMikhalev merged 1 commit intomainfrom
AlexMikhalev merged 1 commit intomainfrom
Conversation
Two remaining CI Main Branch failures after #801: 1. orchestrator_tests: git_diff_baseline() fell back to HEAD~1 for the diff baseline, but shallow CI checkouts lack history before HEAD. Now uses git's empty-tree SHA as stable fallback when root commit lookup returns nothing, making test_orchestrator_compound_review_integration, test_git_diff_matching_changes_spawns, and test_spawn_agent_proceeds_with_git_diff_findings reliable across shallow/fetch-depth=0 CI environments. 2. integration_tests: test_end_to_end_server_workflow was selecting the already-active role (* marker) which fails with exit 1. Now selects a different role (non-current) so the switch is always exercised meaningfully. Refs: #801
AlexMikhalev
added a commit
that referenced
this pull request
Apr 15, 2026
Two remaining CI Main Branch failures after #801: 1. orchestrator_tests: git_diff_baseline() fell back to HEAD~1 for the diff baseline, but shallow CI checkouts lack history before HEAD. Now uses git's empty-tree SHA as stable fallback when root commit lookup returns nothing, making test_orchestrator_compound_review_integration, test_git_diff_matching_changes_spawns, and test_spawn_agent_proceeds_with_git_diff_findings reliable across shallow/fetch-depth=0 CI environments. 2. integration_tests: test_end_to_end_server_workflow was selecting the already-active role (* marker) which fails with exit 1. Now selects a different role (non-current) so the switch is always exercised meaningfully. Refs: #801
AlexMikhalev
added a commit
that referenced
this pull request
Apr 25, 2026
Two remaining CI Main Branch failures after #801: 1. orchestrator_tests: git_diff_baseline() fell back to HEAD~1 for the diff baseline, but shallow CI checkouts lack history before HEAD. Now uses git's empty-tree SHA as stable fallback when root commit lookup returns nothing, making test_orchestrator_compound_review_integration, test_git_diff_matching_changes_spawns, and test_spawn_agent_proceeds_with_git_diff_findings reliable across shallow/fetch-depth=0 CI environments. 2. integration_tests: test_end_to_end_server_workflow was selecting the already-active role (* marker) which fails with exit 1. Now selects a different role (non-current) so the switch is always exercised meaningfully. Refs: #801
AlexMikhalev
added a commit
that referenced
this pull request
Apr 25, 2026
Two remaining CI Main Branch failures after #801: 1. orchestrator_tests: git_diff_baseline() fell back to HEAD~1 for the diff baseline, but shallow CI checkouts lack history before HEAD. Now uses git's empty-tree SHA as stable fallback when root commit lookup returns nothing, making test_orchestrator_compound_review_integration, test_git_diff_matching_changes_spawns, and test_spawn_agent_proceeds_with_git_diff_findings reliable across shallow/fetch-depth=0 CI environments. 2. integration_tests: test_end_to_end_server_workflow was selecting the already-active role (* marker) which fails with exit 1. Now selects a different role (non-current) so the switch is always exercised meaningfully. Refs: #801
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two remaining
CI Main Branchfailures after #801:orchestrator_tests:
git_diff_baseline()fell back toHEAD~1for the diff baseline, but shallow CI checkouts (fetch-depth: 0) lack history beforeHEAD. Now uses git's empty-tree SHA as a stable fallback when the root-commit lookup returns nothing. Fixes:test_orchestrator_compound_review_integrationtest_git_diff_matching_changes_spawnstest_spawn_agent_proceeds_with_git_diff_findingsintegration_tests:
test_end_to_end_server_workflowwas selecting the already-active role (*marker) which returns exit 1. Now selects a different (non-current) role so the switch is always exercised meaningfully.Testing
terraphim_orchestratorintegration tests pass on the fix branchcargo build -p terraphim_agent --test integration_tests --features serverChecklist