Fix #3: terraphim_spawner SpawnContext for per-call working_dir#821
Closed
AlexMikhalev wants to merge 0 commit intomainfrom
Closed
Fix #3: terraphim_spawner SpawnContext for per-call working_dir#821AlexMikhalev wants to merge 0 commit intomainfrom
AlexMikhalev wants to merge 0 commit intomainfrom
Conversation
5974354 to
853df15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs terraphim/adf-fleet#3
Summary
SpawnContextstruct withglobal(),with_working_dir(), andwith_env()constructorsctx: SpawnContextthrough all public spawn methods and internal helpersspawn_processnow usesctx.working_dir(highest priority) overConfiguration.working_dirover spawner default; appliesctx.env_overridesafter spawner and provider env varsSpawnContext::global()preserving existing behaviourTest plan
cargo test -p terraphim_spawner-- 53 passed, 0 failedcargo build --workspace-- cleancargo clippy -p terraphim_spawner -p terraphim_orchestrator -- -D warnings-- cleancargo fmt --check-- no diffNotes
Pre-existing clippy warnings in
terraphim_agent(unrelated dead code) not introduced by this PR. Orchestrator callers useSpawnContext::global()for now; issue #4 will wire real per-project context.