Running machine info even when MPI SIZE is 1#2016
Merged
Conversation
john-science
approved these changes
Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the change?
Removing the
if MPI_SIZE > 1from the_writeMachineInformationmethod.Why is the change being made?
It was noticed a case with 1 rank wasn't getting the machine or system information printed to its log file. There seems to be no technical reason for this, so I'm proposing to remove that "requirement".
Checklist
Tests have been added/updated to verify any new/changed code.None of these reporting utils are tested.docfolder.pyproject.toml.