Skip to content

Running machine info even when MPI SIZE is 1#2016

Merged
opotowsky merged 3 commits intomainfrom
machine-info
Nov 21, 2024
Merged

Running machine info even when MPI SIZE is 1#2016
opotowsky merged 3 commits intomainfrom
machine-info

Conversation

@opotowsky
Copy link
Copy Markdown
Member

What is the change?

Removing the if MPI_SIZE > 1 from the _writeMachineInformation method.

Why is the change being made?

It was noticed a case with 1 rank wasn't getting the machine or system information printed to its log file. There seems to be no technical reason for this, so I'm proposing to remove that "requirement".


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify any new/changed code. None of these reporting utils are tested.
  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science changed the title Run machine info even when MPI SIZE is 1 Running machine info even when MPI SIZE is 1 Nov 21, 2024
@john-science john-science added the feature request Adding a new feature or medium-to-large change label Nov 21, 2024
@opotowsky opotowsky merged commit 04c0670 into main Nov 21, 2024
@opotowsky opotowsky deleted the machine-info branch November 21, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request Adding a new feature or medium-to-large change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants