Cleaning unused parts of HistoryTrackerInterface #2375
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change? Why is it being made?
Cleaning out unused code in the
HistoryTrackerInterface:self.time- Entirely unused in ARMI, or anywhere I can find downstream.self.fullCoreLocations- Entirely unused in ARMI, or anywhere I can find downstream.self.xsHistory- For the past 6 years that ARMI has existed, I can find no code that has ever WRITTEN TO this variable. I have also checked out, internal, projects that use this code, and have never seen this WRITTEN TO.def _getBlockHistoryFileName(self):- Unused.def _getLocationHistoryFileName(self):- Unused.def filterTimeIndices(self):- Unused.NOTE: I have tested this downstream to the best of my ability, and every test and run I could do downstream passes. I am fairly confident that these three class attributes are unused.
(Extra: I also cleaned up the docstrings and f-strings in this file. Sorry, I can't help myself.)
SCR Information
Change Type: trivial
One-Sentence Rationale: The
HistoryTrackerInterfacehas not gotten a lot of love in the past few years, so this is the start of an effort to clean it up and simplify it.One-line Impact on Requirements: NA
Checklist
docfolder.pyproject.toml.