SW-8282 Port web-components CI workflow to Buildkite#761
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
To increment version on merge, please add one of |
|
I think we should probably add release-notes post to this too! It will be helpful in the long run. |
@tommylau523 @constanzauanini does this mean that every time a PR is merged in this repo it generates a slack message and transitions Jira tasks, since every PR creates a new tag? |
I guess so. Perhaps we can update it to not for Patch, but for Minor/Major package updates only, if it gets overbearing. But I don't think we make too many changes to our |
I think I might request that this is done in a separate PR, just to separate concerns. I feel like this repo doesn't need an unreleased.log file, it probably doesn't need Jira transitions, etc |
ice1080
left a comment
There was a problem hiding this comment.
Do we need a publish-rc.yaml equivalent in buildkite if we're doing our other publishing in buildkite?
We didn't have unreleased log, release-notes and jira transitions before. I can remove all that for now and make this PR include just the migration to buildkite. If we want any of those new scripts later, we can open new PRs. |
I didn't do it because publish-rc fires on a "publish rc" PR comment and Buildkite has no native PR-comment trigger. So I left just that in github actions |
be7959d to
3217bfe
Compare
If we want to consolidate our build enviornment on Buildkite only, we can likely setup a webhook trigger on Buildkite for the publish-rc pipeline, and setup GitHub Actions to purely fire a webhook. The pro is to have the same build enviornment as the rest of the pipeline. The con is that we will have to manage two pipelines for one action in that case. |
ice1080
left a comment
There was a problem hiding this comment.
Just one open question, but approving for now to unblock
No description provided.