Fix checking focusMode instead of zoomMode #728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the zoomMode was incorrectly using the focusMode value, ensuring that zoomMode is now independently determined.
- Changed the reference in the zoomMode check from focusMode to zoomMode.
Comments suppressed due to low confidence (1)
ios/ReactNativeCameraKit/CKCameraViewComponentView.mm:227
- The code now correctly checks zoomMode instead of focusMode. Please verify that all other usage of focusMode and zoomMode remains consistent and that this change doesn't affect related functionality.
_view.zoomMode = [zoomMode isEqualToString:@"on"] ? CKZoomModeOn : CKZoomModeOff;
Collaborator
|
Thank you for that very precise contribution @WilliamWelsh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
zoomMode is checking focusMode instead of zoomMode, making it copy focusMode state instead of being independent
How did you test this change?
By running locally