fix: remove orientation listener on camera unmount #745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the iOS orientation observer is not removed when camera is unmounted. It stays active and registers every orientation change. Looking at the code, it seems that there is code that should remove the observer, but it doesn't do it's job.
How did you test this change?
I've tested this on iPhone 16 Pro, with the fix and without. Without the fix, if you add logs to the
self.setVideoOrientationToInterfaceOrientation()and go back to a previous screen from the camera screen, it still prints logs on each orientation change.With the fix, the logs only appear when the camera is present in the current screen.