Skip to content

Implement verbose logging flag for all commands. Wrap t2 provision error in verbose mode. Fixes gh-216#217

Closed
rwaldron wants to merge 1 commit intotessel:masterfrom
rwaldron:216
Closed

Implement verbose logging flag for all commands. Wrap t2 provision error in verbose mode. Fixes gh-216#217
rwaldron wants to merge 1 commit intotessel:masterfrom
rwaldron:216

Conversation

@rwaldron
Copy link
Copy Markdown
Contributor

No description provided.

@rwaldron
Copy link
Copy Markdown
Contributor Author

This may be partly addressed in #215, so let's wait until that lands and I will see where this fits after that.

@rwaldron rwaldron force-pushed the 216 branch 2 times, most recently from 4055bae to 14446b7 Compare July 24, 2015 16:43
Comment thread Gruntfile.js Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thank god. I was just editing my grunt file to only run one file with grunt nodeunit. This is much better.

@johnnyman727
Copy link
Copy Markdown
Contributor

@rwaldron Looks good. I only have the one suggestion about the options var.

How do you feel like the verbose option usage differs from passing DEBUG= to the command? It seems like we might want to centralize on one debugging method. What do you think?

@rwaldron
Copy link
Copy Markdown
Contributor Author

Updated.

How do you feel like the verbose option usage differs from passing DEBUG= to the command? It seems like we might want to centralize on one debugging method. What do you think?

I'm not sure actually... Let me think about that a bit more. In the meantime, I can move the grunt task to another PR

@Frijol
Copy link
Copy Markdown
Member

Frijol commented Aug 16, 2015

Any update on this?

@johnnyman727
Copy link
Copy Markdown
Contributor

@rwaldron should we close this PR? The one thing I liked about it was the ability to specify a nodeunit file to run.

@johnnyman727
Copy link
Copy Markdown
Contributor

@rwaldron closing this for now since we already have the Grunt single file tests in master. Feel free to re-open if you think this PR is relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants