Skip to content

Conversation

@marrts
Copy link
Contributor

@marrts marrts commented Aug 8, 2025

For CollisionCoeffData and TrajOptCollisionConfig

Copy link
Contributor

@Levi-Armstrong Levi-Armstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be best to update CollisionCoeffData to resemble the CollisionMarginData.

@marrts
Copy link
Contributor Author

marrts commented Aug 13, 2025

I think it would be best to update CollisionCoeffData to resemble the CollisionMarginData.

If you mean in structure, I'm not sure what you mean by that. I don't think it makes sense to use CollisionMarginPairData as a object in the class, nor do I think the increment, scale, or getMax methods make sense to include in CollisionCoeffData.

If you mean in terms of yaml processing, CollisionMarginData doesn't actually have yaml methods defined, so there is nothing to reference there

EDIT Or do you mean just adding a getter method to get all the pairs that have been set.

@marrts
Copy link
Contributor Author

marrts commented Aug 13, 2025

I think it would be best to update CollisionCoeffData to resemble the CollisionMarginData.

If you mean in structure, I'm not sure what you mean by that. I don't think it makes sense to use CollisionMarginPairData as a object in the class, nor do I think the increment, scale, or getMax methods make sense to include in CollisionCoeffData.

If you mean in terms of yaml processing, CollisionMarginData doesn't actually have yaml methods defined, so there is nothing to reference there

EDIT Or do you mean just adding a getter method to get all the pairs that have been set.

I added set default, get default, and get pair data methods to CollisionCoeffData

@marrts marrts force-pushed the trajopt_common_yaml_conversions branch from e8ce9b0 to d4287cd Compare August 13, 2025 14:51
@marrts marrts requested a review from Levi-Armstrong August 13, 2025 15:31
@Levi-Armstrong Levi-Armstrong force-pushed the trajopt_common_yaml_conversions branch from d4287cd to 568ffe3 Compare August 18, 2025 20:01
@Levi-Armstrong Levi-Armstrong force-pushed the trajopt_common_yaml_conversions branch from a1e15ca to 64875b3 Compare August 19, 2025 02:46
@Levi-Armstrong Levi-Armstrong merged commit 36dcc46 into tesseract-robotics:master Aug 19, 2025
6 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants